-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bridge-ui-v2)!: bridge UI version 2.1 #15775
Conversation
hey @KorbinianK this should be okay to merge into main anyways (unstable). so long as this passes some manual testing we can go through, can we try to deploy this to prod? basically, merging in the release-please PR after my PR merges (this one: #15782). i'll also need to quickly test out in my taiko-mono fork 🍻 PS: in regards to hotfixes and internal environment, we have a few ideas. I don't think we'll need a hotfix branch, because we should be able to just merge the hotfix to main, and merge a release-please PR. But that's only if we are never maintaining two divergent versions. If we need a hotfix setup later, we can easily add that so that we can patch a prod release somewhere further back than the HEAD of main. also, we can manage separate environment variables with vercel, so if we want to do deployments to "staging" (internal devnet) on every main branch, we can do that (and i think that makes sense, also can add e2e playwright stuff in that pipeline). |
@d1onys1us Not sure what to do with breaking changes though (new ABIs and contract calls coming very soon) that rely on those being deployed, guess they need to go together in a release somehow? But going forward, we won't have too many of those breaking changes for the UI anymore I hope. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15775 +/- ##
=======================================
Coverage 26.93% 26.93%
=======================================
Files 104 104
Lines 6140 6140
=======================================
Hits 1654 1654
Misses 4306 4306
Partials 180 180
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is huge, due to our changes in branching it was left pending for a while. Sorry about that. Original commit timestamps were lost when rebasing/cherry-picking.
Internal UI will be updated for testing asap.
New design for ETH/ERC 20
Refactor & Optimize
Dependency update
wagmi 2.6
-> lots of breaking changesviem 2.7
walletconnect 4
(wagmi 2)Note:
does not include new proof/multihop or invocation delay setup yet.