Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): remove two step processing #16744

Merged
merged 9 commits into from
Apr 16, 2024
Merged

feat(protocol): remove two step processing #16744

merged 9 commits into from
Apr 16, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 16, 2024 •
edited
Loading

  • removed "refundTo" and "memo" from messages and vaults.
  • reordered field in bridge messagen and vault's op structs to make it use fewer slots.

@dantaik dantaik marked this pull request as ready for review April 16, 2024 05:08
@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
guardian-dashboard-hekla ✅ Ready (Inspect) Visit Preview Apr 16, 2024 5:25am

@dantaik dantaik mentioned this pull request Apr 16, 2024
Merged
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 16, 2024 •
edited
Loading

feat(protocol): remove two step processing

Generated at commit: 6c274c6b806c9af74658e42e9186af6ffa2ba0d2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
4
39
47
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik
Copy link
Contributor Author

dantaik commented Apr 16, 2024

  • removed "refundTo" and "memo" from messages and vaults.
  • reordered field in bridge messagen and vault's op structs to make it use fewer slots

@dantaik dantaik merged commit 2b57c55 into bridge_improvement Apr 16, 2024
6 checks passed
@dantaik dantaik deleted the remove_two_step_processing branch April 16, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Awaiting requested review from Brechtpd

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dantaik