refactor(protocol): multiple improvements on implementation and tests

.github/workflows/guardian-prover-health-check-ui.yml

@@ -28,8 +28,6 @@ jobs:
   #     vercel_org_id: ${{ secrets.VERCEL_ORG_ID }}
   #     vercel_token: ${{ secrets.VERCEL_TOKEN }}
 
-
-
   deploy_guardians-ui_hekla_preview:
     if: ${{ github.event.pull_request.draft == false  && !startsWith(github.head_ref, 'release-please') }}
     needs: build-and-test

.github/workflows/protocol.yml

@@ -10,6 +10,13 @@ on:
       - "!packages/protocol/docs/**"
       - "!packages/protocol/simulation/**"
       - "!packages/protocol/deployments/**"
+      - "!packages/protocol/script/layer2/hekla/**"
+      - "!packages/protocol/script/layer2/mainnet/**"
+      - "!packages/protocol/script/layer1/hekla/**"
+      - "!packages/protocol/script/layer1/mainnet/**"
+      - "!packages/protocol/script/layer1/preconf/**"
+      - "!packages/protocol/script/layer1/provers/**"
+      - "!packages/protocol/script/layer1/team/**"
     branches-ignore:
       - release-please--branches--**
 

packages/protocol/README.md

@@ -15,40 +15,39 @@ To install dependencies:
 foundryup && pnpm install
 ```
 
-## Compilation and Testing
+## Compilation
 
 Taiko’s protocol is split between Layer 1 (L1) and Layer 2 (L2). The smart contracts need to be compiled and tested separately for each layer:
 
-### Layer 1 (Ethereum, Duncan Hardfork)
-
-To compile, run tests, and generate the storage layout for L1:
+To compile and generate the storage layout for L1:
 
 ```bash
 pnpm compile:l1
-pnpm test:l1
 pnpm layout:l1
 ```
 
-### Layer 2 (Taiko, Shanghai Hardfork)
-
 Similarly, for L2:
 
 ```bash
 pnpm compile:l2
-pnpm test:l2
 pnpm layout:l2
 ```
 
-### Compile and Test for Both Layers
-
-To compile and test contracts for both L1 and L2 at once:
+To compile and generate the storage layout for both layers:
 
 ```bash
 pnpm compile
-pnpm test
 pnpm layout
 ```
 
+## Testing
+
+```bash
+pnpm test:l1
+pnpm test:l2
+pnpm test
+```
+
 ## Layer 2 Genesis Block
 
 ### Generating a Dummy Genesis Block

packages/protocol/TEST_TREE.md

@@ -0,0 +1,65 @@
+# Test tree definitions
+
+Below is the graphical definition of the contract tests implemented on [the test folder](./test)
+
+```
+TaikoL1Test
+└── When a new TaikoL1 with 10 block slots and a sync interval of 5
+    ├── When test1
+    │   └── When case-1
+    │       ├── It initializes the genesis block
+    │       ├── It initializes the first transition
+    │       ├── It finalizes the genesis block
+    │       ├── It counts total blocks as 1
+    │       ├── It retrieves correct data for the genesis block
+    │       ├── It retrieves correct data for the genesis block's first transition
+    │       ├── It fails to retrieve block 1, indicating block not found
+    │       ├── It returns the genesis block and its first transition for getLastVerifiedTransitionV3
+    │       └── It returns empty data for getLastSyncedTransitionV3 but does not revert
+    ├── When proposing one more block with custom parameters
+    │   └── When case-2
+    │       ├── It places the block in the first slot
+    │       ├── It sets the block's next transition id to 1
+    │       ├── It the returned metahash should match the block's metahash
+    │       ├── It matches the block's timestamp and anchor block id with the parameters
+    │       ├── It total block count is 2
+    │       └── It retrieves correct data for block 1
+    ├── When proposing one more block with default parameters
+    │   └── When case-3
+    │       ├── It places the block in the first slot
+    │       ├── It sets the block's next transition id to 1
+    │       ├── It the returned metahash should match the block's metahash
+    │       ├── It sets the block's timestamp to the current timestamp
+    │       ├── It sets the block's anchor block id to block.number - 1
+    │       ├── It total block count is 2
+    │       └── It retrieves correct data for block 1
+    ├── When proposing one more block with default parameters but nonzero parentMetaHash
+    │   └── When case-4
+    │       ├── It does not revert when the first block's parentMetaHash matches the genesis block's metahash
+    │       └── It reverts when proposing a second block with a random parentMetaHash
+    └── When proposing 9 blocks as a batch to fill all slots
+        ├── When propose the 11th block before previous blocks are verified
+        │   └── When case-5
+        │       └── It reverts indicating no more slots available
+        ├── When prove all existing blocks with correct first transitions
+        │   ├── When proposing the 11th block after previous blocks are verified
+        │   │   └── When case-6
+        │   │       ├── It total block count is 12
+        │   │       └── It getBlockV3(0) reverts indicating block not found
+        │   └── When case-7
+        │       ├── It total block count is 10
+        │       ├── It returns the block 9 and its first transition for getLastVerifiedTransitionV3
+        │       └── It returns the block 5 and its first transition for getLastSyncedTransitionV3
+        ├── When prove all existing blocks with wrong first transitions
+        │   ├── When prove all existing blocks with correct first transitions2
+        │   │   └── When case-8
+        │   │       ├── It total block count is 10
+        │   │       ├── It returns the block 9 and its first transition for getLastVerifiedTransitionV3
+        │   │       └── It returns the block 5 and its first transition for getLastSyncedTransitionV3
+        │   └── When case-9
+        │       ├── It total block count is 10
+        │       ├── It returns the genesis block and its first transition for getLastVerifiedTransitionV3
+        │       └── It returns empty data for getLastSyncedTransitionV3 but does not revert
+        └── When case-10
+            └── It total block count is 10
+```