ci(repo): fix some failed ci issues #18515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mask-pp
changed the title
YoGhurt111
approved these changes
Nov 25, 2024
RogerLamTd
approved these changes
Nov 25, 2024
This was referenced Nov 25, 2024
| @@ -322,6 +322,11 @@ func (c *Client) CalculateBaseFee( | |||
| return nil, fmt.Errorf("failed to fetch parent gas excess: %w", err) | |||
| } | |||
| } | |||
| // The time of l1Head should always be greater than that of l2Head. | |||
| // Since the block.Time after anvil rollback is smaller than the original one, the timestamp has to be modified here. | |||
| if currentTimestamp < l2Head.Time { | |||
There was a problem hiding this comment.
Still think changing the code here is probly not the best way to resolve this test issue, let me figure out later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.