Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol): fix documentation #18694

Merged
merged 2 commits into from
Jan 2, 2025
Merged

chore(protocol): fix documentation #18694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b36f44
chore(protocol): fix documentation
RogerLamTd Jan 2, 2025
d6a7f58
Merge branch 'main' into protocol-typo
davidtaikocha Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/protocol/test/layer1/automata-attestation/utils/DcapTestUtils.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ contract DcapTestUtils {
// Converts a string to a hexstring (of bytes type)
// https://ethereum.stackexchange.com/questions/39989/solidity-convert-hex-string-to-bytes

// Convert an hexadecimal character to their value
// Convert a hexadecimal character to their value
function _fromHexChar(uint8 c) private pure returns (uint8) {
if (bytes1(c) >= bytes1("0") && bytes1(c) <= bytes1("9")) {
return c - uint8(bytes1("0"));
Expand All @@ -249,7 +249,7 @@ contract DcapTestUtils {
revert("failed to convert hex value");
}

// Convert an hexadecimal string to raw bytes
// Convert a hexadecimal string to raw bytes
function _fromHex(string memory s) private pure returns (bytes memory) {
bytes memory ss = bytes(s);
require(ss.length % 2 == 0); // length must be even
Expand Down
2 changes: 1 addition & 1 deletion packages/protocol/test/shared/bridge/Bridge2_sendMessage.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ contract BridgeTest2_sendMessage is BridgeTest2 {
vm.expectRevert(Bridge.B_INVALID_CHAINID.selector);
bridge.sendMessage(message);

// an bridge has been registered for remoteChainId
// a bridge has been registered for remoteChainId
message.destChainId = remoteChainId;
bridge.sendMessage(message); // id = 0

Expand Down