Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: net, net/http: add enforcement hooks #55

Open
bradfitz opened this issue Feb 9, 2023 · 0 comments
Open

patch: net, net/http: add enforcement hooks #55

bradfitz opened this issue Feb 9, 2023 · 0 comments
Labels
tsgo

Comments

@bradfitz
Copy link
Member

bradfitz commented Feb 9, 2023 •
edited
Loading

Summary: let us add some safety checks inside our control plane that people don't accidentally introduce network operations while holding locks or inside database transactions
Upstream status: seems unlikely to be accepted
Importance: safety check for corp only (https://github.com/tailscale/corp/issues/8944), not tailscale/tailscale.
Example prior commit: 13373ca and #68
@bradfitz bradfitz added the tsgo label Feb 9, 2023
bradfitz added a commit that referenced this issue Feb 9, 2023
@bradfitz
[tailscale] net: add enforcement hooks
03b725f 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this issue Feb 9, 2023
Merged
bradfitz added a commit that referenced this issue Feb 9, 2023
@bradfitz
[tailscale] net: add enforcement hooks
b178e9c 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 9, 2023
@bradfitz
[tailscale] net: add enforcement hooks
4960183 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Feb 9, 2023
@bradfitz
[tailscale] net: add enforcement hooks
13373ca 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit to tailscale/tailscale that referenced this issue Feb 9, 2023
@bradfitz
go.toolchain.rev: bump Go toolchain
263ab9c 
For tailscale/go#55 experimentation in another repo primarily,
but this is our source of truth, so we bump here.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this issue Feb 9, 2023
Merged
bradfitz added a commit to tailscale/tailscale that referenced this issue Feb 9, 2023
@bradfitz
go.toolchain.rev: bump Go toolchain
9e4d993 
For tailscale/go#55 experimentation in another repo primarily,
but this is our source of truth, so we bump here.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
phirework added a commit that referenced this issue Jun 21, 2023
@phirework
[tailscale] net: add enforcement hooks
5ce33ff 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Jenny Zhang <jz@tailscale.com>
(Cherry-picked from 13373ca)
@phirework phirework mentioned this issue Jun 21, 2023
Merged
phirework added a commit that referenced this issue Jun 21, 2023
@phirework
[tailscale] net: add enforcement hooks
479855c 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Jenny Zhang <jz@tailscale.com>
(Cherry-picked from 13373ca)
phirework added a commit that referenced this issue Jun 22, 2023
@phirework
[tailscale] net: add enforcement hooks
9c10558 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Jenny Zhang <jz@tailscale.com>
(Cherry-picked from 13373ca)
bradfitz added a commit that referenced this issue Jul 23, 2023
@bradfitz
net/http: add enforcement hook to Transport.RoundTrip, like our net ones
7924b46 
Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Jul 23, 2023
@bradfitz
net/http: add enforcement hook to Transport.RoundTrip, like our net ones
aee11cc 
Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz mentioned this issue Jul 23, 2023
Merged
@bradfitz bradfitz changed the title patch: net: add enforcement hooks patch: net, net/http: add enforcement hooks Jul 23, 2023
bradfitz added a commit that referenced this issue Jul 23, 2023
@bradfitz
net/http: add enforcement hook to Transport.RoundTrip, like our net ones
1ecb1d6 
Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Jul 23, 2023
@bradfitz
net/http: add enforcement hook to Transport.RoundTrip, like our net ones
a96a9ed 
Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
awly pushed a commit that referenced this issue Feb 7, 2024
@phirework @awly
[tailscale] net: add enforcement hooks
46817d1 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Jenny Zhang <jz@tailscale.com>
(Cherry-picked from 13373ca)
awly pushed a commit that referenced this issue Feb 7, 2024
@bradfitz @awly
net/http: add enforcement hook to Transport.RoundTrip, like our net ones
be9ef3d 
Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
awly pushed a commit that referenced this issue Feb 7, 2024
@phirework @awly
[tailscale] net: add enforcement hooks
043e09a 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Jenny Zhang <jz@tailscale.com>
(Cherry-picked from 13373ca)
awly pushed a commit that referenced this issue Feb 7, 2024
@bradfitz @awly
[tailscale] net/http: add enforcement hook to Transport.RoundTrip, li…
8df9488 
…ke our net ones

Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz added a commit that referenced this issue Aug 21, 2024
@bradfitz
[tailscale] net/http: add enforcement hook to Transport.RoundTrip, li…
6783622 
…ke our net ones

Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
(cherry picked from commit 8df9488)
bradfitz added a commit that referenced this issue Aug 21, 2024
@bradfitz
[tailscale] net/http: add enforcement hook to Transport.RoundTrip, li…
47693b9 
…ke our net ones

Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
(cherry picked from commit 8df9488)
bradfitz pushed a commit that referenced this issue Aug 21, 2024
@phirework @bradfitz
[tailscale] net: add enforcement hooks
8c00619 
Updates #55
Updates tailscale/corp#8944

Signed-off-by: Jenny Zhang <jz@tailscale.com>
(Cherry-picked from 13373ca)
(cherry picked from commit 043e09a)
bradfitz added a commit that referenced this issue Aug 21, 2024
@bradfitz
[tailscale] net/http: add enforcement hook to Transport.RoundTrip, li…
19afa83 
…ke our net ones

Updates #55
Updates tailscale/corp#12702

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
(cherry picked from commit 8df9488)
bradfitz pushed a commit that referenced this issue Aug 21, 2024
@phirework @bradfitz
[tailscale] net, net/http: add enforcement hooks
ab59d02 
Updates #55
Updates tailscale/corp#8944
Updates tailscale/corp#12702

Signed-off-by: Jenny Zhang <jz@tailscale.com>
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>

(Cherry-picked from 13373ca)
(cherry picked from commit 043e09a)
(cherry picked from commit 8df9488)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tsgo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradfitz