patch: net: add socket read/write hooks #58
Labels
Comments
mihaip
added a commit
that referenced
this issue
Feb 28, 2023
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace) function. Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58
mihaip
added a commit
that referenced
this issue
Feb 28, 2023
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace function). Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58
mihaip
added a commit
that referenced
this issue
Feb 28, 2023
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace function). Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58
mihaip
added a commit
that referenced
this issue
Mar 8, 2023
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58
mihaip
added a commit
that referenced
this issue
Mar 8, 2023
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58
mihaip
added a commit
that referenced
this issue
Mar 8, 2023
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58
mihaip
added a commit
that referenced
this issue
Mar 8, 2023
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58
phirework
added a commit
that referenced
this issue
Jun 21, 2023
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace function). Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from fb11c0d)
phirework
added a commit
that referenced
this issue
Jun 21, 2023
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90)
phirework
added a commit
that referenced
this issue
Jun 21, 2023
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace function). Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from fb11c0d)
phirework
added a commit
that referenced
this issue
Jun 21, 2023
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90)
phirework
added a commit
that referenced
this issue
Jun 22, 2023
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace function). Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from fb11c0d)
phirework
added a commit
that referenced
this issue
Jun 22, 2023
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90)
awly
pushed a commit
that referenced
this issue
Feb 7, 2024
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace function). Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from fb11c0d)
awly
pushed a commit
that referenced
this issue
Feb 7, 2024
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90)
awly
pushed a commit
that referenced
this issue
Feb 7, 2024
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace function). Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from fb11c0d)
awly
pushed a commit
that referenced
this issue
Feb 7, 2024
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90)
bradfitz
pushed a commit
that referenced
this issue
Aug 21, 2024
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90) (cherry picked from commit 51a96ad) (cherry picked from commit aff7d04)
bradfitz
pushed a commit
that referenced
this issue
Aug 21, 2024
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90) (cherry picked from commit 51a96ad) (cherry picked from commit aff7d04)
bradfitz
pushed a commit
that referenced
this issue
Aug 21, 2024
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90) (cherry picked from commit 51a96ad) (cherry picked from commit aff7d04) Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
pushed a commit
that referenced
this issue
Aug 21, 2024
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90) (cherry picked from commit 51a96ad) (cherry picked from commit aff7d04) Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary: lets us instrument all socket I/O so that we can see when it happens (and thus its effect on battery life).
Upstream status: seems unlikely to be accepted
Importance: instrumentation for mobile clients, not load-bearing/critical for app functionality. tailscale/corp#9230 has details
Example prior commit: 6234152
The text was updated successfully, but these errors were encountered: