android: make custom url check case-insensitive #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agottardo
approved these changes
Sep 18, 2024
barnstar
reviewed
Sep 18, 2024
| @@ -36,7 +36,9 @@ class LoginWithCustomControlURLViewModel : CustomLoginViewModel() { | |||
| // localAPIClient will use the default server if we give it a broken URL, | |||
| // but we can make sure we can construct a URL from the input string and | |||
| // ensure it has an http/https scheme | |||
| when (urlStr.startsWith("http") && urlStr.contains("://") && urlStr.length > 7) { | |||
| when (urlStr.startsWith("http", ignoreCase = true) && | |||
There was a problem hiding this comment.
Double checking - will Http:// work though? (on all browsers?)
I probably copied this from Apple, where it does not. If it doesn't, we could be nice and just lowercase the scheme for them.
There was a problem hiding this comment.
Or if it's possible, modify the input field so it doesn't auto-capitalize
There was a problem hiding this comment.
This worked for me. I like this suggestion, done!
Fixes tailscale/corp#23210 Signed-off-by: kari-ts <kari@tailscale.com>
barnstar
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tailscale/corp#23210