android: make tailnet lock setup view focusable and clickable #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-use a shared InteractionSource for focusing and clicking to ensure they rely on the same state and to coordinate so that visual feedback is shown on scroll without affecting the click InteractionSource -use LocalIndication to ensure that the click interaction maintains the visual feedback when combined with focusable -use onFocusChanged to explicitly track the focus state Updates tailscale/corp#21737 Signed-off-by: kari-ts <kari@tailscale.com>
agottardo
approved these changes
Oct 17, 2024
agottardo
pushed a commit
that referenced
this pull request
Oct 17, 2024
-use a shared InteractionSource for focusing and clicking to ensure they rely on the same state and to coordinate so that visual feedback is shown on scroll without affecting the click InteractionSource -use LocalIndication to ensure that the click interaction maintains the visual feedback when combined with focusable -use onFocusChanged to explicitly track the focus state Updates tailscale/corp#21737 Signed-off-by: kari-ts <kari@tailscale.com> (cherry picked from commit 354a903)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-use a shared InteractionSource for focusing and clicking to ensure they rely on the same state and to coordinate so that visual feedback is shown on scroll without affecting the click InteractionSource
-use LocalIndication to ensure that the click interaction maintains the visual feedback when combined with focusable
-use onFocusChanged to explicitly track the focus state
Updates tailscale/corp#21737