Allow specifying ETag value while setting ACLs #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knyar
force-pushed
the
knyar/acl_etag
branch
from
972bb45 to
717b0b8
Compare
maisem
approved these changes
Nov 29, 2022
tailscale/client.go
Outdated
Comment on lines
111
to
114
| for k, v := range headers { | ||
| req.Header.Set(k, v) | ||
| } | ||
|
|
There was a problem hiding this comment.
should this be done before setting the other headers so that this can't overwrite them?
There was a problem hiding this comment.
I actually thought it might be useful to overwrite them, but at this point it does not matter and doing this earlier seems safer.
knyar
force-pushed
the
knyar/acl_etag
branch
3 times, most recently
from
3adf780 to
5b5eae7
Compare
This adds a `WithETag` option that allows specifying an ETag value while writing ACL contents. Also, a few missing ACL file fields have been added based on https://tailscale.com/kb/1018/acls/ Signed-off-by: Anton Tolchanov <anton@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
WithETagoption that allows specifying an ETag value while writing ACL contents.Also, a few missing ACL file fields have been added based on https://tailscale.com/kb/1018/acls/
Updates tailscale/terraform-provider-tailscale#182
Signed-off-by: Anton Tolchanov anton@tailscale.com