Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OAuth client credentials #44

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

clstokes
Copy link
Collaborator

@clstokes clstokes commented Mar 8, 2023

What this PR does / why we need it:

Allows configuring the tailscale client with OAuth Client ID and OAuth Client. On instantiation the Client will generate a new API key against the Tailscale OAuth token endpoint.

Which issue this PR fixes:

Fixes #42

tailscale/client.go Outdated Show resolved Hide resolved
tailscale/client.go Outdated Show resolved Hide resolved
tailscale/client.go Outdated Show resolved Hide resolved
Copy link
Member

@willnorris willnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicitly marking 'request changes' based on earlier comments about using the oauth2-provided http.Client

@clstokes
Copy link
Collaborator Author

@knyar @willnorris I believe this is ready for another review.

tailscale/client.go Outdated Show resolved Hide resolved
@clstokes
Copy link
Collaborator Author

@knyar @willnorris, mind giving this another look?

Copy link
Member

@willnorris willnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for carrying this all the way through.

Copy link
Contributor

@knyar knyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@clstokes clstokes force-pushed the clstokes/oauth-credentials branch 2 times, most recently from 4a0bfca to 90dae64 Compare March 27, 2023 23:26
Signed-off-by: Cameron Stokes <cameron@cameronstokes.com>
Signed-off-by: Cameron Stokes <cameron@tailscale.com>
@clstokes clstokes force-pushed the clstokes/oauth-credentials branch from 90dae64 to 9cd84c8 Compare March 27, 2023 23:37
@willnorris willnorris merged commit 936e156 into tailscale:main Mar 27, 2023
@clstokes
Copy link
Collaborator Author

For those following along I rebased and squashed my commits here to sign and signoff on the commits to pass the commit signature verification requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAUTH support
4 participants