-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OAuth client credentials #44
Add support for OAuth client credentials #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicitly marking 'request changes' based on earlier comments about using the oauth2-provided http.Client
@knyar @willnorris I believe this is ready for another review. |
@knyar @willnorris, mind giving this another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for carrying this all the way through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
4a0bfca
to
90dae64
Compare
Signed-off-by: Cameron Stokes <cameron@cameronstokes.com> Signed-off-by: Cameron Stokes <cameron@tailscale.com>
90dae64
to
9cd84c8
Compare
For those following along I rebased and squashed my commits here to sign and signoff on the commits to pass the commit signature verification requirement. |
What this PR does / why we need it:
Allows configuring the tailscale client with OAuth Client ID and OAuth Client. On instantiation the Client will generate a new API key against the Tailscale OAuth token endpoint.
Which issue this PR fixes:
Fixes #42