Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost explorer #1003

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Cost explorer #1003

merged 2 commits into from
Sep 27, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Sep 27, 2023

Problem

#811

Solution

Fixed the period filter for "Last 6 months" to exclude this month and added a new period filter for "This month" in cost explorer.

Changes Made

  • Added a date helper function for getting first day of this month.
  • Added the UI option for selecting "This month" period & subsequent changes to support that option.

How to Test

  • Try cost explorer with "This month" period, it'll show data for only this month.
  • Try cost explorer with "Last 6 months" period, it won't include this month's data anymore.

Screenshots

image
image

Notes

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy
@naisayer

Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Copy link
Contributor

@Kolawole99 Kolawole99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a million for the fix @Azanul

@mlabouardy mlabouardy added the ui label Sep 27, 2023
@mlabouardy mlabouardy added this to the v3.1.1 milestone Sep 27, 2023
@mlabouardy mlabouardy merged commit 774669c into tailwarden:develop Sep 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cost explorer requested date ranges are wrong
3 participants