Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce normalization of line ending to LF #1007

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

shivarm
Copy link
Contributor

@shivarm shivarm commented Sep 27, 2023

Problem

fixes: #970

[Provide a brief description of the problem that you are trying to solve with this pull request.]

Solution

[Provide a detailed explanation of the solution you are proposing, including any relevant code snippets or screenshots.]

Changes Made

  • [List the changes you made in this pull request, including any new features or bug fixes.]

How to Test

[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]

Screenshots

[Include screenshots, if relevant, to help reviewers understand the changes you made.]

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Sep 27, 2023

@shivam-sharma7 should we also add an .editorconfig and define end_of_line? That way the editor takes care of it as well when saving files. https://editorconfig.org/

@shivarm
Copy link
Contributor Author

shivarm commented Sep 27, 2023

@Traxmaxx This is enough and if that will require then we can do a seprate PR.

@mlabouardy mlabouardy merged commit e9526ff into tailwarden:develop Oct 2, 2023
@shivarm shivarm deleted the line-ending branch October 3, 2023 00:24
@shivarm shivarm restored the line-ending branch December 11, 2023 04:44
@shivarm shivarm deleted the line-ending branch December 11, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Consistent Line Breaks in VS Code for Windows
3 participants