Initial Lint Support #1055
Merged
Initial Lint Support #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubhindia <shubhindia123@gmail.com>
Signed-off-by: shubhindia <shubhindia123@gmail.com>
Signed-off-by: shubhindia <shubhindia123@gmail.com>
shubhindia
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
Azanul
requested changes
Oct 9, 2023
.github/workflows/lint.yml
Outdated
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| args: --timeout=30m |
There was a problem hiding this comment.
Suggested change
| args: --timeout=30m | |
| args: --timeout=2m | |
| version: v1.54 |
There was a problem hiding this comment.
It will fail with timeout error. Clean lint check takes around 140s on my M1 Pro Macbook. Currently it takes around 6 mins to run in GA ref: https://github.com/shubhindia/komiser/actions/runs/6454534229
There was a problem hiding this comment.
Reduced the timeout to 10mins now. It would be much faster with cache, but 10 mins is a reasonable time to run lint I think.
Co-authored-by: Azanul Haque <42029519+Azanul@users.noreply.github.com>
Signed-off-by: shubhindia <shubhindia123@gmail.com>
shubhindia
force-pushed
the
fix/silent-the-linter
branch
from
874dcd5
to
8d754f7
Compare
Azanul
approved these changes
Oct 9, 2023
mlabouardy
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are no lint checks in place currently.
Solution
This PR adds golangci-lint support. The lint checks are done via github-actions only.
Changes Made
How to Test
golangci-lint runkomiser start --config=config.tomlChecklist