-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add owner tags for jobs and pods #1064
Conversation
Signed-off-by: shubhindia <shubhindia123@gmail.com>
Signed-off-by: shubhindia <shubhindia123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opencost currently classifies jobs and cronjobs under jobs, ref: https://github.com/opencost/opencost/blob/26b5ba12ac73e612b5328969debf2056478ef0d7/pkg/costmodel/costmodel.go#L128C1-L138C1
There is no separate aggregation by cronjob.
@mlabouardy What kind of coverage are we looking for regarding k8s cron jobs? |
My bad. I didn't check the opencost price aggregation. So, I think here it makes more sense to just add owner tags than having a separate service for cronJob? Or we can continue having cronJobs without cost? |
as they belong to jobs, I would say collecting the owner tag would be enough |
@shubhindia They you go |
Signed-off-by: shubhindia <shubhindia123@gmail.com>
@Azanul pushed the changes. I think same can be done for pods as well. Tags can help group them together |
Signed-off-by: shubhindia <shubhindia123@gmail.com>
Feel free to do the same in this PR only as I don't think it's that big of a change. Also, do update the PR title and description accordingly |
Signed-off-by: shubhindia <shubhindia123@gmail.com>
Problem
Currently, komiser doesn't support listing cronJobs
Solution
This PR adds support for listing cronJobs and their pricing as well
Changes Made
How to Test
komiser start --config=config.toml
Screenshots
Checklist