Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git): favicon.ico & azure.svg files always showing modified #1085

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix(git): favicon.ico & azure.svg files always showing modified #1085

merged 1 commit into from
Oct 12, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Oct 12, 2023

Problem

favicon.ico & azure.svg always show as modified even in fresh cloned repo.

Solution

Configured gitattributes to consider .ico files as binary and updated line endings in azure.svg

Notes

  • .gitattributes were probably set after azure.svg was created and then the file never changed.
  • I assumed that there's a similar issue with favicon.ico although this can be checked using hexdump but it doesn't really matter since it's actually a binary file.

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy

@Azanul
fix(git): 2 files always showing modified
90924d8 
Signed-off-by: Azanul <azanulhaque@gmail.com>
mlabouardy
mlabouardy approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a million

@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 12, 2023
@mlabouardy mlabouardy added the cli label Oct 12, 2023
@mlabouardy mlabouardy merged commit 8bcc098 into tailwarden:develop Oct 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

@greghub greghub Awaiting requested review from greghub

@Traxmaxx Traxmaxx Awaiting requested review from Traxmaxx

Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Azanul @mlabouardy