Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add empty state for empty page filters apllied on resource expl… #1096

Merged

Conversation

shavidze
Copy link
Contributor

@shavidze shavidze commented Oct 16, 2023

Problem

Here is a Ticket
Currently, when the results for the filters applied on the Resources Explorer page are empty, the page renders an empty canvas.

Solution

Implemented the empty state covered on the designs so it's clear there are no results for the filters selected.

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

[@victorgaard]

Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explorer - Komiser

@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 17, 2023
@mlabouardy mlabouardy merged commit ee90608 into tailwarden:develop Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants