Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat-1081] Render empty state explorer (no resources) #1101

Merged

Conversation

umrkhn
Copy link
Contributor

@umrkhn umrkhn commented Oct 16, 2023

Fixes: #1081

Problem

Explorer page renders an empty canvas when there are no resources.

Solution

The Explorer page should render an EmptyState component when there are no resources available.

Changes Made

  • added an asset purplin/devops.svg.
  • added support for the devops svg in the EmptyState component.
  • rendered the EmptyState component when there are no resources on the explorer page
  • fixed a small className typo in /components/explorer/DependencyGraph.tsx

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 19, 2023
@mlabouardy mlabouardy added the ui label Oct 19, 2023
@mlabouardy mlabouardy merged commit 9651f32 into tailwarden:develop Oct 20, 2023
3 checks passed
@umrkhn
Copy link
Contributor Author

umrkhn commented Oct 20, 2023

Sorry I was busy didn't update my PR but thanks @mlabouardy for resolving the conflicts. Although there was still one change I had to do will update in my next PR.

@umrkhn umrkhn deleted the feature/1081-render-empty-state-explorer branch October 27, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty state for Explorer (no resources)
4 participants