Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: golangci lint #1102

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix: golangci lint #1102

merged 3 commits into from
Oct 17, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Oct 16, 2023 •
edited
Loading

Problem

golangci-lint was had stopped running due to golangci/golangci-lint-action#135
Also, it was running on push events instead of pull_request events

Solution

skipping pkg cache

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Azanul and others added 3 commits October 16, 2023 23:46
@Azanul
fix: golangci lint
3163755 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
fix: golangci lint
8a86970 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
Merge branch 'develop' into develop
fea6167
@Azanul Azanul marked this pull request as ready for review October 17, 2023 04:38
@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 17, 2023
mlabouardy
mlabouardy approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Azanul

@mlabouardy mlabouardy merged commit 90b5320 into tailwarden:develop Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

@greghub greghub Awaiting requested review from greghub

@Traxmaxx Traxmaxx Awaiting requested review from Traxmaxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Azanul @mlabouardy