feat: fetch DynamoDB costs for RCUs and WCUs #1111
Conversation
Traxmaxx
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi and
greghub
as code owners
…ts. Rename log info
| // there is something strange going on when using pricing client with regions other than us-east-1 | ||
| // https://discord.com/channels/932683789384183808/1117721764957536318/1162338171435090032 |
There was a problem hiding this comment.
There was a problem hiding this comment.
Does this mean there could be potentially different prices returned per region? 🤔
There was a problem hiding this comment.
At the same place they say
The AWS Region is the API endpoint for the Price List Query API. The endpoints aren't related to product or service attributes.
So, IDTS but it's worth checking out
There was a problem hiding this comment.
evem the cost explorer gives only one endpoint https://docs.aws.amazon.com/cost-management/latest/userguide/ce-api.html
There was a problem hiding this comment.
I talked with @mlabouardy and I will create a helper to take care of this in a new PR in the next days.
There was a problem hiding this comment.
I don't think it's worth fixing as the refactor work @AvineshTripathi is doing will probably address this as well. Since the client will be created only once.
There was a problem hiding this comment.
I don't think it's worth fixing as the refactor work @AvineshTripathi is doing will probably address this as well. Since the client will be created only once.
Awesome, good to know thanks for the heads-up! I think the PR is good to go from my side if you agree as well. Thanks a lot for the thorough review!
providers/aws/dynamodb/tables.go
Outdated
| RCUCharges := awsUtils.GetCost(priceMap["AWS-DynamoDB-ProvisionedReadCapacityUnits"], awsUtils.Int64PtrToFloat64(provisionedRCUs)) | ||
| PWUCharges := awsUtils.GetCost(priceMap["AWS-DynamoDB-ProvisionedWriteCapacityUnits"], awsUtils.Int64PtrToFloat64(provisionedWCUs)) |
There was a problem hiding this comment.
Where did you get these keys for priceMap?
There was a problem hiding this comment.
I think the correct ones are DDB-ReadUnits and DDB-WriteUnits
There was a problem hiding this comment.
nit: we should use WCU instead of PWU to keep consistency with AWS docs
There was a problem hiding this comment.
@Azanul got them from metrics docs https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/metrics-dimensions.html and from other sources as well. Where did you find the values you mentioned above?
There was a problem hiding this comment.
The link is for metrics reference.
If you log the pricing output which is used to create the price map, you'll find the key values I provided
There was a problem hiding this comment.
Nice catch, works better and actually returns values now for some entities. Will log it from now on to make sure! It's weird that there is no error being returned though 🤔
describe table has been needed since tailwarden#1111
* feat: add missing dynamodb action to policy.json describe table has been needed since #1111 * feat: add missing lambda action to policy.json list event source mappings has been needed since #1040 * feat: add missing iam action to policy.json list users has been needed since #991 * fix: correct s3 permission for list buckets api call listbucket iam action is for the contents of a bucket * feat: add missing code suite actions to policy.json needed since #1216, #1229, and #1228
* feat: add missing dynamodb action to policy.json describe table has been needed since #1111 * feat: add missing lambda action to policy.json list event source mappings has been needed since #1040 * feat: add missing iam action to policy.json list users has been needed since #991 * fix: correct s3 permission for list buckets api call listbucket iam action is for the contents of a bucket * feat: add missing code suite actions to policy.json needed since #1216, #1229, and #1228
Problem
We have no costs on DynamoDB resources
Solution
Fetch costs of DynamoDB resources
Changes Made
aws:dynamodb:tables.goto fetch RCUs and WCUs through table detailsHow to Test
Util can be tested with
go test ./providers/aws/dynamodb/ // should print // ok github.com/tailwarden/komiser/providers/aws/dynamodb 0.290sOtherwise start komiser locally and see if DynamoDB costs are being fetched properly.
Screenshot
Notes
First time doing Go. Feel free to give any tips on what to improve!
Checklist