(feature/0457-support-amazon-cloudfront-function): Support Amazon Clo…

[jolo-dev]

Collect Amazon CloudFront function #457

Solution

Add to Cloudfront Functions a new file functions.go

Changes Made

• new file provider/aws/cloudfront/functions.go

How to Test

Create a new Cloudfront functions: https://us-east-1.console.aws.amazon.com/cloudfront/v3/home?region=us-east-1#/functions/create

Screenshots

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

• Code follows the contributing guidelines
• Changes have been thoroughly tested
• Documentation has been updated, if necessary
• Any dependencies have been added to the project, if necessary

Reviewers

[Traxmaxx]

🙌

[jolo-dev]

@Traxmaxx the dashboard fails because of the missing Toast component: https://discord.com/channels/932683789384183808/933353577102061669/1165250794417836072

[Traxmaxx]

@Traxmaxx the dashboard fails because of the missing Toast component: https://discord.com/channels/932683789384183808/933353577102061669/1165250794417836072

Hey thanks! I'm aware and try to get someone from the maintainers to help me review open PRs to get the fix in asap!

[bishal7679]

@mlabouardy This changes has already been raised by this PR #1131 #1123
and had to close it due to checks failing!

[AvineshTripathi]

Hey @bishal7679 your PR also adds something some details to distributions, I would recommend you to review this PR to see if it matches to what your changes are and we can remove those from your PR. However we will make sure you get added as a collaborator for this PR.

This is just to make sure both get credits for the amazing work, however i can only do that when both you and @jolo-dev are ready for it. Thanks!

[bishal7679]

Hey @bishal7679 your PR also adds something some details to distributions, I would recommend you to review this PR to see if it matches to what your changes are and we can remove those from your PR. However we will make sure you get added as a collaborator for this PR.

This is just to make sure both get credits for the amazing work, however i can only do that when both you and @jolo-dev are ready for it. Thanks!

@AvineshTripathi I completely support this! Wouldn't it be good?? get PR #1131 merged first [PS:- might get complicated for merge conflict] after then this PR #1127 could be addon since both are adding same file functions.go and in #1131 dynamic pricing and more metrics being used and #1127 its invocation metric can be added there to make the calculation more efficient??
WDYT @jolo-dev ?

[jolo-dev]

@AvineshTripathi I believe the one of #1131 is a bit more sophisticated. However, there might be a few changes needed. He got the Duration which I couldn't find. @bishal7679 Have you tried and that worked?
L138 and L158.
And I am not sure about the Namespace of L92.

[AvineshTripathi]

Great! I keep this to you'll and let me know how you want to proceed or need any assitance.

[bishal7679]

Hope it helps!
REF :- metricname

[bishal7679]

LGTM!