Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore OVH provider #1144

Merged
merged 24 commits into from
Nov 6, 2023
Merged

Restore OVH provider #1144

merged 24 commits into from
Nov 6, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Oct 27, 2023

Problem

#912

How to Test

  • Try to configure your OVH account with Komiser like
[[ovh]]
  name="Test"
  endpoint="ovh-eu"
  application_key="my_app_key"
  application_secret="my_application_secret"
  my_consumer_key="my_consumer_key"
  • See if resources are correctly being fertched

Notes

  • Haven't tested it yet

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
@mlabouardy mlabouardy added the ovh label Oct 30, 2023
@mlabouardy mlabouardy added this to the v3.1.3 milestone Oct 30, 2023
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul Azanul changed the title Ovh Restore OVH provider Oct 30, 2023
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Copy link

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this provider, it's a very good idea ☺️
Just a suggestion, is it possible to change "OVH" to "OVHcloud" for the name of the cloud provider?

Thanks

dashboard/utils/providerHelper.ts Outdated Show resolved Hide resolved
Signed-off-by: Azanul <azanulhaque@gmail.com>
Azanul and others added 2 commits November 2, 2023 17:18
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
@mlabouardy mlabouardy merged commit 3dd4211 into tailwarden:develop Nov 6, 2023
3 checks passed
@Azanul Azanul mentioned this pull request Nov 9, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants