Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show navigation and zoom utilities in resources explorer #1070 #1145

Merged

Conversation

faisal7008
Copy link
Contributor

@faisal7008 faisal7008 commented Oct 27, 2023

Problem

The current implementation of the DependencyGraph component in the Komiser dashboard lacks a feature to show the current zoom level and temporarily disable node dragging.

fixes #1070

Solution

I have implemented a zoom input that allows users to either zoom in, zoom out, or manually enter a zoom value. Additionally, I have added functionality that enables or disables the dragging of nodes.

Changes Made

  • Added a Number Input component to the Storybook, available in both small and large variants.
  • Enhanced the functionality of the zoom utility using the NumberInput component.
  • Optimized rendering performance by implementing debouncing for state updates.
  • Added a feature to enable or disable node dragging.

How to Test

  • Go to Resource explorer, check out the zoom utility and node dragging toggle button at the bottom right corner of the page

Screenshots

komiser.zoom.utility.1070.compressed.mp4

check out the video

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@AllieMendes

Copy link
Contributor

@Kolawole99 Kolawole99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlabouardy mlabouardy added this to the v3.1.4 milestone Nov 2, 2023
@mlabouardy mlabouardy merged commit d6882fe into tailwarden:develop Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show navigation and zoom utilities in Resources Explorer
4 participants