-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display node details in sidepanel #1072 #1151
feat: display node details in sidepanel #1072 #1151
Conversation
dashboard/components/inventory/components/InventorySidePanel.tsx
Outdated
Show resolved
Hide resolved
dashboard/components/inventory/components/InventorySidePanel.tsx
Outdated
Show resolved
Hide resolved
dashboard/components/inventory/components/InventorySidePanel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the new changes. Thanks a ton for this great PR! Also thanks for adding all the new Storybook components! 🔥 💚
Appreciate the feedback! Glad you like the changes. Let me know if you need anything else. 😊 |
@faisal7008 great job on this one 👏🏻 could you please fix the conflict so I can merge the PR :) |
Problem
The current implementation of the Resources Explorer does not provide details about a node when it is clicked on the sidepanel.
fixes #1072
Solution
To address this issue, we propose to add a side panel that displays details about a node when it is clicked. This information will be fetched from the API using the resource ID, which is part of the node data.
Changes Made
How to Test
[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]
Screenshots
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@Traxmaxx @mlabouardy @AllieMendes