Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resource fetching performance improvement for OVH #1211

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: Resource fetching performance improvement for OVH #1211

merged 2 commits into from
Nov 16, 2023

Conversation

tanbirali
Copy link
Contributor

@tanbirali tanbirali commented Nov 16, 2023 •
edited by Azanul
Loading

Problem

#1205

Solution

Submitting the tasks to worker pool instead of executing synchronously.

Changes Made

  • Updated respective function signatures
  • Used providers.WorkerPool.SubmitTask to submit the task to worker pool

Checklist

@Azanul Azanul changed the title fix(1205): Resource fetching performance improvement for OVH fix: Resource fetching performance improvement for OVH Nov 16, 2023
@mlabouardy mlabouardy merged commit e53b263 into tailwarden:develop Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azanul Azanul Azanul approved these changes

@mlabouardy mlabouardy Awaiting requested review from mlabouardy mlabouardy is a code owner

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

@greghub greghub Awaiting requested review from greghub

@Traxmaxx Traxmaxx Awaiting requested review from Traxmaxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanbirali @Azanul @mlabouardy