Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Phillip and Jake to the codeoweners file, so they are prompted … #1270

Merged
merged 2 commits into from
Dec 7, 2023
Merged

added Phillip and Jake to the codeoweners file, so they are prompted … #1270

merged 2 commits into from
Dec 7, 2023

Conversation

jakepage91
Copy link
Contributor

…to review PRs automatically

Problem

CODEOWNERS file didn't reflect the full maintainers team

Changes Made

Added Jake and Phillip.

Azanul
Azanul approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see my name in the list but I think it still works since I do get mails and GH notifications

@jakepage91
Copy link
Contributor Author

True! Let me update that @Azanul

@Azanul Azanul merged commit 864286d into develop Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azanul Azanul Azanul approved these changes

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

@greghub greghub Awaiting requested review from greghub

@Traxmaxx Traxmaxx Awaiting requested review from Traxmaxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakepage91 @mlabouardy @Azanul