-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache costexplorer API #1280
Cache costexplorer API #1280
Conversation
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep the cache file as temp file with a scope of application life cycle
we want to keep the file even when application turns off or crashes. Since it charges user to make requests, we'll have the user to set frequency for this separately having 1 week by default. |
we might wanna change the location of the file and not keep it in current dir |
open to suggestions |
I would keep it in /tmp dir maybe |
Putting it in /tmp would clear it on device/container reboot |
@Azanul for now we can keep it in same place, please update the branch I ll give approve |
Problem
Solution
Notes
region
argument as it'd be useful in the near futureChecklist
Reviewers
@mlabouardy @jakepage91