-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overlay opacity #1283
fix: overlay opacity #1283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @ManishBisht777 thanks a million, the overlay issue looks to be addressed thanks a million for that. One thing that I have noticed is that on the Cloud Accounts Page a bug has reappeared (not sure if it's due to the changes done here) There is a solid div over the cloud accounts which shouldn't be there (not there in the current stable version of Komiser v3.1.6) so just wondering if you could check that. Here is the link to the original div bug. #1257
Thanks again.
sure @jakepage91 i'll look into the issue and fix it in this pr itself |
LGTM however would suggest someone with frontend experience review why the remove div from the cloud_account even existed |
@AllieMendes Could you please verify that this is the intended change. |
@Azanul I have checked with Allie, and this was the intended change. I still see the div for some reason when building the binary from Manish's fork. Avinesh has confirmed on his side. @Azanul if you test and see that the div is actually gone, then we can move ahead here. It's probably I'm doing something wrong (even though not sure what.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
Thanks a million @ManishBisht777 ! |
##Fixes #1279
Changes Made
How to Test
/inventory
Screenshots
Checklist