Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overlay opacity #1283

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Conversation

ManishBisht777
Copy link
Contributor

##Fixes #1279

Changes Made

  • changed overlay opacity to match Figma

How to Test

  • Click on leave feedback the overlay is slightly transparent
  • Click on save as view while creating custom views on the /inventory

Screenshots

image
image

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Copy link
Contributor

@jakepage91 jakepage91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @ManishBisht777 thanks a million, the overlay issue looks to be addressed thanks a million for that. One thing that I have noticed is that on the Cloud Accounts Page a bug has reappeared (not sure if it's due to the changes done here) There is a solid div over the cloud accounts which shouldn't be there (not there in the current stable version of Komiser v3.1.6) so just wondering if you could check that. Here is the link to the original div bug. #1257
Screenshot 2023-12-15 at 11 35 46

Thanks again.

@ManishBisht777
Copy link
Contributor Author

sure @jakepage91 i'll look into the issue and fix it in this pr itself

@AvineshTripathi
Copy link
Collaborator

LGTM however would suggest someone with frontend experience review why the remove div from the cloud_account even existed

@Azanul
Copy link
Collaborator

Azanul commented Dec 18, 2023

@AllieMendes Could you please verify that this is the intended change.

@jakepage91
Copy link
Contributor

@Azanul I have checked with Allie, and this was the intended change. I still see the div for some reason when building the binary from Manish's fork. Avinesh has confirmed on his side. @Azanul if you test and see that the div is actually gone, then we can move ahead here. It's probably I'm doing something wrong (even though not sure what.)

Copy link
Contributor

@jakepage91 jakepage91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@jakepage91
Copy link
Contributor

Thanks a million @ManishBisht777 !

@jakepage91 jakepage91 merged commit 07f5207 into tailwarden:develop Dec 18, 2023
3 checks passed
@ManishBisht777 ManishBisht777 deleted the 1279-modal-overlay branch December 19, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal underlying overlay has full opacity
5 participants