Onboarding wizard enhancements #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Azanul
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub,
Traxmaxx and
jakepage91
as code owners
| go fetchResourcesForAccount(c, account, handler.db, []string{}) | ||
|
|
||
| cron := gocron.NewScheduler(time.UTC) | ||
| _, err = cron.Every(1).Hours().Do(func() { |
There was a problem hiding this comment.
Wouldn't this be another cron that keeps on running. Lets say a new acc was added and before that the main core cron was already running now with the addition of new clou acc this cron starts too every other hour for same acc. Wont this be redundant
There was a problem hiding this comment.
main cron doesn't have the acc covered by this one
There was a problem hiding this comment.
In case of multiple addition of cloud acc there will be multiple crons running
There was a problem hiding this comment.
That's true, for now
There was a problem hiding this comment.
sure for time being we can use it but definately we can improve this a lot
AvineshTripathi
approved these changes
Jan 10, 2024
mlabouardy
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Screenshots
Checklist
Reviewers
@jakepage91 @mlabouardy @AllieMendes