feat: 6 month cost data history #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Azanul
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi and
greghub
as code owners
| log.Warn("Failed to extract resources from cost explorer output:", err) | ||
| } | ||
| for i, resource := range resources { | ||
| resource.ResourceId = "OLD_RESOURCE_" + strconv.Itoa(i) |
There was a problem hiding this comment.
how about naming it "OLD_RESOURCE_"+resource.ResourceID for future query if there maybe any
There was a problem hiding this comment.
cost explorer api doesn't give out anything that can be used as resource.ResourceID
mlabouardy
approved these changes
Jan 29, 2024
AvineshTripathi
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Komiser only records cost data from the instant it's started, ignoring past data
Solution
Use AWS cost explorer API to fetch and store 6 months cost history
Screenshots
[Include screenshots, if relevant, to help reviewers understand the changes you made.]
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist