Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloudtrail, SecretsManger and DataSync #1353

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Add Cloudtrail, SecretsManger and DataSync #1353

merged 9 commits into from
Feb 27, 2024

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Feb 23, 2024

Problem

Missing AWS services Cloudtrail, SecretsManger and DataSync

Solution

Added respective services

Notes

I couldn't create a DataSync agent so I've left it to point to the list page

@Azanul
feat: cloudtrail trails support
52c6bcf 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
feat: secretsmanager secret support
eeba4ee 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
fix: secretsmanager secret support
edcc7d0 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
feat: datasync agent support
a3b951f 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul Azanul changed the title Aws services Add missing AWS services Feb 23, 2024
@Azanul Azanul changed the title Add missing AWS services Add Cloudtrail, SecretsManger and DataSync Feb 23, 2024
mlabouardy
mlabouardy requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you include those functions here
also include the new permissions to the IAM policy here

@Azanul
Copy link
Collaborator Author

Azanul commented Feb 23, 2024

here

Thanks a lot for pointing it out

@Azanul
fix: secretsmanager spelling
04f4e39 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
fix: secretsmanager spelling
1887cac 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
feat: add to supported service list
1d3b542 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul
feat: add service policy
6e3bdda 
Signed-off-by: Azanul <azanulhaque@gmail.com>
AvineshTripathi
AvineshTripathi reviewed Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

providers/aws/cloudtrail/trail.go Show resolved Hide resolved
providers/aws/cloudtrail/trail.go Show resolved Hide resolved
providers/aws/datasync/agents.go Show resolved Hide resolved
AvineshTripathi
AvineshTripathi approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for delay

@Azanul
Copy link
Collaborator Author

Azanul commented Feb 27, 2024

apologies for delay

No worries, happens to the best of us

@Azanul Azanul merged commit 1db81b3 into tailwarden:develop Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvineshTripathi AvineshTripathi AvineshTripathi approved these changes

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@greghub greghub Awaiting requested review from greghub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Azanul @mlabouardy @AvineshTripathi