Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: service and metadata fields add to CSV export #1360

Conversation

Mahiro-T
Copy link
Contributor

@Mahiro-T Mahiro-T commented Mar 3, 2024

Problem

Added Service Name and Metadata as I wanted them when downloading CSV from Inventory on Komiser.
I know you can sort by Service Name, etc. on Komiser, but I would like to do this on CSV as well.
I also added Metadata because I want to see what is associated with a resource such as an Instance (e.g. EBS).

Solution

get datas and headers are added to the CSV generation points(handlers/csv_handler.go) in the backend.

Changes Made

  • Get metadata and service name from data fetching from database.

How to Test

I downloaded csv from komiser frontend.

Screenshots

Downloaded csv's screenshot. (Account ID, etc. are rewritten manually.)
image

Notes

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary (I searched the documentation and could not find any mention of CSV.)
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

Add to metadata and service column to export csv
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for opening your Pull Request ! 🙂 While a Tailwarden team member takes a look at your PR we would like to invite you to join our official Discord server, where you can interact directly with other contributors and Tailwarden team members. Link here: https://discord.tailwarden.com

@Azanul Azanul merged commit 06b21f8 into tailwarden:develop Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants