added dashboard contributor video to dashboard readme #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgaard
suggested changes
Mar 16, 2023
dashboard/README.md
Outdated
|
|
||
| ## Walkthrough video | ||
|
|
||
| <div style={{ |
There was a problem hiding this comment.
Hey @jakepage91 I'm seeing this when viewing the README file:
I believe GitHub doesn't accept iframes in its markdown. Maybe we could leverage something like adding the thumbnail as image and a link to the youtube video?
An example: https://gist.github.com/bitsurgeon/acd769ae3236c48a433e0acb11784c2e
There was a problem hiding this comment.
Thanks! you might be right. I thought it might work since in the documentation this notation is the one used in the markdown files for the documentation. Let me try out your proposal. Obrigado!
mlabouardy
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there @victorgaard
Added the walkthrough video to the readme if that is cool with you.