Bigquery #687
Bigquery #687
Conversation
providers/gcp/bigquery/bigquery.go
Outdated
| Name: tableMetadata.Name, | ||
| FetchedAt: time.Now(), | ||
| Tags: tags, | ||
| Link: fmt.Sprintf("https://console.cloud.google.com/compute/instancesDetail/zones/%s/instances/%s?project=%s", tableMetadata.Location, tableMetadata.Name, client.GCPClient.Credentials.ProjectID), |
There was a problem hiding this comment.
This URL looks not right for a BQ Table, for example this would be the URL to a table:
https://console.cloud.google.com/bigquery?referrer=search&authuser=1&project=[PROJECTID]&ws=!1m5!1m4!4m3!1s[WORSKPACE]!2s[DATASET]!3s[TABLENAME]
So you'd need to fill in [PROJECTID], [WORKSPACE], [DATASET] and [TABLENAME] from the data you grab
There was a problem hiding this comment.
As I cannot set up the BQ table I am not able to sure how to get the workspace field can you help me with that please
There was a problem hiding this comment.
Hmm ok, I would have to check how to do this myself. I'll get back at you
There was a problem hiding this comment.
actually, the workspace isn't needed, you just need to provide the following:
https://console.cloud.google.com/bigquery?project={PROJECT_NAME}&page=dataset&p={PROJECT_NAME}&d={DATASET}
There was a problem hiding this comment.
Hey Thanks @mlabouardy can you confirm if PROJECT_NAME is actually PROJECT_NAME field or is it PROJECT_ID and also DATASET here is the ID?
There was a problem hiding this comment.
It's client.GCPClient.Credentials.ProjectID for PROJECT_NAME from @mlabouardy snippet
There was a problem hiding this comment.
can you review it now @eneskaya thank you!
Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
Signed-off-by: AvineshTripathi <avineshtripathi1@gmail.com>
fixes #665
Changes Made
Added BigQuery table support
Note: the code is not been tested with the real time tables in GCP however according to the documentation/go sdk for gcp it should work
Checklist