Fix PostgreSQL query for all tags #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneskaya
force-pushed
the
feature/tech-1003
branch
from
6842290 to
1c427b7
Compare
mlabouardy
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an error when querying with the "all tags" filter (see issue #660) which was caused by the
tagscolumn in theresourcestable sometimes being set tonull, leading the SQL query to fail.This PR fixes that by setting the default value of
Tagsfield in theResourcesmodel to[]. Furthermore, it's possible that users who installed komiser before, have already resources withnulltags. That's why I introduce here a way to do migrations and also the first migration, which sets the default value of[]in the tags column for all resources.