Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Parse Used Created Policies from AWS #730

Conversation

ShubhamPalriwala
Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala commented Apr 17, 2023

Problem

Closes #729

Solution

Saved up a lot of pre-created default policies (adding 0 to the cloud costs) and their rows from the inventory.
ANDDD
Performance gains by an approx 10x 🚀
How:

  • Before: Querying atleast 1000 predefined policies from 22 AWS zones
  • After: Querying only user created policies (realistically worst case 100? ) from 22 AWS zones

Before

Screenshot_2023-04-17-19-03-32_4920x1920

After

Screenshot_2023-04-17-19-11-31_4920x1920

Notes

However, we still iterate through the 1000 something extra policies so there definites is a scope for efficiency and performance gains!
10x gains lesssgooo!

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@mlabouardy mlabouardy added the aws label Apr 17, 2023
@mlabouardy mlabouardy added this to the v3.0.13 milestone Apr 17, 2023
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 🚀

@mlabouardy mlabouardy merged commit 1f0a50e into tailwarden:develop Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants