Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for AWS EC2 Spot Instance Requests #738

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Add Support for AWS EC2 Spot Instance Requests #738

merged 3 commits into from
Apr 20, 2023

Conversation

ShubhamPalriwala
Copy link
Contributor

Problem

Closes #509

Solution

Screenshot_2023-04-20-18-52-43_4920x1920

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@mlabouardy mlabouardy added the aws label Apr 20, 2023
@mlabouardy mlabouardy added this to the v3.0.13 milestone Apr 20, 2023
eneskaya
eneskaya suggested changes Apr 20, 2023
View reviewed changes
providers/aws/ec2/spot_instances.go Outdated
return resources, err
}

for _, request := range output.SpotInstanceRequests {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nicer to call this var instance or spotInstance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! PTAL now @eneskaya

@eneskaya eneskaya merged commit d5bb1c6 into tailwarden:develop Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneskaya eneskaya eneskaya approved these changes

Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
v3.0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@ShubhamPalriwala @eneskaya @mlabouardy