Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/522 support aws ec2 vpc endpoint #748

Conversation

Kolawole99
Copy link
Contributor

@Kolawole99 Kolawole99 commented Apr 26, 2023

Problem

Supporting AWS EC2 VPC Endpoint

Solution

This solution adds support for VPC Endpoint using the aws-sdk-go-v2 that supports VPC Endpoint.

Changes Made

  • Adds VPC Endpoint support to the AWS Provider

How to Test

The changes do not require any custom configuration. The AWS Provider has been added to the project and the configuration steps are here in the documentation.

To populate data from AWS, you might need to create a VPC endpoint attached to a VPC network.

Screenshots

[Include screenshots, if relevant, to help reviewers understand the changes you made.]

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@jakepage91 @mlabouardy

@Kolawole99 Kolawole99 marked this pull request as ready for review April 26, 2023 15:57
@mlabouardy mlabouardy added the aws label Apr 26, 2023
@mlabouardy mlabouardy added this to the v3.0.14 milestone Apr 26, 2023
@mlabouardy mlabouardy merged commit 9de804e into tailwarden:develop Apr 27, 2023
@Kolawole99 Kolawole99 deleted the feature/522-support-aws-ec2-vpc-endpoint branch July 5, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants