Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): add RDS db proxy endpoint capabilities #803

Merged

Conversation

siddarthkay
Copy link
Contributor

Problem

Ability to view RDS Db Proxy endpoint inputs does not exist.

Solution

This PR adds a new db_proxy_endpoints.go file which queries the AWS Go SDK and implements support for returning RDS ProxyEndpoints.
An entry has also been made to aws.go to make sure rds.ProxyEndpoints is included

Changes Made

fixes #565

How to Test

Apply filter in Dashboard:

  • Cloud Provider is AWS
  • Cloud Service is RDS DB Proxy endpoint

and you should be able to see RDS ProxyEndpoint resources.

Screenshots

WIP

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a million, @siddarthkay 🚀

@mlabouardy mlabouardy changed the base branch from master to develop May 22, 2023 14:56
@mlabouardy mlabouardy added the aws label May 22, 2023
@mlabouardy mlabouardy added this to the v3.0.17 milestone May 22, 2023
@mlabouardy mlabouardy merged commit fcc2e26 into tailwarden:develop May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Amazon RDS db-proxy-endpoint
2 participants