-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Webhook Integration #826
Custom Webhook Integration #826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamPalriwala if the user tried to create a Slack alert on an existing alerts
table, the following error is returned:
This can be fixed by writing a migration script to add isSlack
column (if doesn't exists) to the table upon Komiser launch (see example)
hi @mlabouardy, I have made the request changes except for the migration script, can you help me with that please :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Problem
Closes #787
Till now, users could only add Slack Alerts, this PR introduces the ability to add custom webhooks extensively.
Solution
alert
fromslackAlert
isSlack
for each alert to distinguish the method.How to Test
Screenshots
Will make a walkthrough screen recording and put it up for easier verification!Here you gohttps://www.loom.com/share/969eafd580d84b71917ff9d9c9f6c253
Notes
go-bindata-assetfs -o template.go dist/ dist/assets/images/
so if any of the maintainers can help me by running that for me on this PR, it'd be really helpful (maintainers have edit access to this).PS: This was my first time dealing with React as well as Next so do let me know if by any chance any anti-practice is followed (I tried my best not to!). 🥂 to a productive weekend haha!
Checklist