Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dependency graph for AWS EC2 and EIP #849

Closed

Conversation

AvineshTripathi
Copy link
Collaborator

@AvineshTripathi AvineshTripathi commented Jun 10, 2023

fixes #785

Note: the graph will also consist of previous relations that now donot exists. Example: lets say there was a EC2 and now it is deleted but as that data is present in the db the graph will show that.
Reason: we put a live resource along with previous resources in the db
Solution to be looked for some other PR: have a health status field that tells about the current status

@AvineshTripathi AvineshTripathi changed the base branch from master to develop June 10, 2023 16:27
@AvineshTripathi AvineshTripathi changed the title Addedd Dependency graph for AWS EC2 and EIP Added Dependency graph for AWS EC2 and EIP Jun 10, 2023
@mlabouardy mlabouardy added the aws label Jun 11, 2023
@mlabouardy mlabouardy added this to the v3.0.19 milestone Jun 11, 2023
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @AvineshTripathi 👏🏻 I've few comments to improve code readability :)

Also, I wasn't able to display the graph even though I had EC2 instances running in my AWS account:
Screenshot 2023-06-14 at 08 39 51
Screenshot 2023-06-14 at 08 40 48

dashboard/pages/dashboard.tsx Outdated Show resolved Hide resolved
dashboard/package.json Outdated Show resolved Hide resolved
dashboard/services/settingsService.ts Outdated Show resolved Hide resolved
handlers/views_handler.go Outdated Show resolved Hide resolved
internal/api/v1/endpoints.go Outdated Show resolved Hide resolved
@mlabouardy
Copy link
Collaborator

Hey @AvineshTripathi let us know once those fixes are done so we can proceed with the PR :)

handlers/resources_handler.go Outdated Show resolved Hide resolved
migrations/20230619100000_add_new_relation_field.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the following error now when I'm using Postgres:
Screenshot 2023-06-23 at 11 29 44

@ShubhamPalriwala
Copy link
Contributor

@AvineshTripathi, looks like the issue Mohamed faced can be avoided in the future if we migrate away from the any and use strict typecasting.
Let me know if you are up for it, would be glad to collaborate in any way and help get this feature get the most out of TS.

Also, let's sync up so we can also start adding the support across all the AWS resources we support!

Let me know what you think of it

@AvineshTripathi
Copy link
Collaborator Author

AvineshTripathi commented Jun 24, 2023

@ShubhamPalriwala this is backend error (I need help with postgresql setup) and mainly a postgresql however for frontend the error can be removed by changing func to ForEach instaed map

@ShubhamPalriwala
Copy link
Contributor

As far as I think, the error is basically because the runtime does not know the type of the nodes variable. If we type it strictly, we would get that error (and if others) at the compile time itself and we would handle it there itself resulting in a smoother runtime experience!

@AvineshTripathi
Copy link
Collaborator Author

Sure lets assign types to all. However I am currently moving towards a very compact schedule so I dont think I'll have bandwidth to resolve this for now. I am open to anyone to take this branch and add the proper ts support.

Also I am still struggling to setup postgresql to replicate the error so help in that is appreciated

@mlabouardy
Copy link
Collaborator

Sure lets assign types to all. However I am currently moving towards a very compact schedule so I dont think I'll have bandwidth to resolve this for now. I am open to anyone to take this branch and add the proper ts support.

Also I am still struggling to setup postgresql to replicate the error so help in that is appreciated

maybe you could add the types to this PR @ShubhamPalriwala ?

@ShubhamPalriwala
Copy link
Contributor

yessir, will do next and ping here once done!

@AvineshTripathi
Copy link
Collaborator Author

I made an attempt to resolve it in one go today that was not a perfect attempt though but it did give me idea about blockers so please ping me if you need help with the code explanation or some weird errors(I did came across those) @ShubhamPalriwala

@ShubhamPalriwala ShubhamPalriwala changed the base branch from develop to wip-dep-graph July 3, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Dependencies Graph
3 participants