-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dependency graph for AWS EC2 and EIP #849
Added Dependency graph for AWS EC2 and EIP #849
Conversation
686da9e
to
af7d4ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @AvineshTripathi 👏🏻 I've few comments to improve code readability :)
Also, I wasn't able to display the graph even though I had EC2 instances running in my AWS account:
dashboard/components/dashboard/components/dependency-graph/nodes/nodes.tsx
Outdated
Show resolved
Hide resolved
Hey @AvineshTripathi let us know once those fixes are done so we can proceed with the PR :) |
ffd6de5
to
42a8e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvineshTripathi, looks like the issue Mohamed faced can be avoided in the future if we migrate away from the Also, let's sync up so we can also start adding the support across all the AWS resources we support! Let me know what you think of it |
@ShubhamPalriwala this is backend error (I need help with postgresql setup) and mainly a postgresql however for frontend the error can be removed by changing func to ForEach instaed map |
As far as I think, the error is basically because the runtime does not know the type of the |
Sure lets assign types to all. However I am currently moving towards a very compact schedule so I dont think I'll have bandwidth to resolve this for now. I am open to anyone to take this branch and add the proper ts support. Also I am still struggling to setup postgresql to replicate the error so help in that is appreciated |
maybe you could add the types to this PR @ShubhamPalriwala ? |
yessir, will do next and ping here once done! |
I made an attempt to resolve it in one go today that was not a perfect attempt though but it did give me idea about blockers so please ping me if you need help with the code explanation or some weird errors(I did came across those) @ShubhamPalriwala |
4ed2d26
to
55a8e7c
Compare
fixes #785
Note: the graph will also consist of previous relations that now donot exists. Example: lets say there was a EC2 and now it is deleted but as that data is present in the db the graph will show that.
Reason: we put a live resource along with previous resources in the db
Solution to be looked for some other PR: have a health status field that tells about the current status