Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cost calculation for elasticache instances #871

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

jakepage91
Copy link
Contributor

Problem

Adding cost calculation for Elasticache instances (issue-369)
[Provide a brief description of the problem that you are trying to solve with this pull request.]

Solution

[Provide a detailed explanation of the solution you are proposing, including any relevant code snippets or screenshots.]

Changes Made

  • [List the changes you made in this pull request, including any new features or bug fixes.]

How to Test

[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]

Screenshots

[Include screenshots, if relevant, to help reviewers understand the changes you made.]

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely to the point sir @jakepage91! 🚀

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlabouardy mlabouardy merged commit 2ea2c90 into develop Jun 30, 2023
2 checks passed
@mlabouardy mlabouardy deleted the feat/cacl-cost-elasticache branch June 30, 2023 08:42
@mlabouardy mlabouardy added this to the v3.0.20 milestone Jun 30, 2023
@mlabouardy mlabouardy added the aws label Jun 30, 2023
@jakepage91
Copy link
Contributor Author

Thanks team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants