refact: move interface #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreliberato
requested review from
mlabouardy and
ShubhamPalriwala
as code owners
ShubhamPalriwala
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Hey @alexandreliberato, thanks for the quick fix! lgtm! i'll trigger the build once and then over to you @mlabouardy
mlabouardy
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Move interface AutoScalingGroupClient from it's own file to autoscaling_groups.go
Solution
Remove interface's file and copy it to the new place.
Changes Made
Remove interface's file and copy it to the new place.
How to Test
Run 'make test'.
Screenshots
Notes
#872
#872
Checklist
Reviewers
@