-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: collect aws rds auto backup resources #886
feat: collect aws rds auto backup resources #886
Conversation
ebe69cd
to
1e4c1cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @siddarthkay thanks a lot for the concise and well cleaned-up PR 💯 ! The current implementation looks perfect! I just wanted to know, will you be able to add cost calculation for the Auto Backups as well? It would really help the project in getting important cost calculation up that is not directly provided in the AWS console. Let me know what you think
Reference: https://aws.amazon.com/blogs/database/demystifying-amazon-rds-backup-storage-costs/
Hey @ShubhamPalriwala : Ofcourse I can add few commits to this branch which include cost calculation. |
Hey @siddarthkay, how's it going? let me know if you need any help here 🙌🏼 ! |
Hey @ShubhamPalriwala and @mlabouardy : I did some research the other day and found that calculating the cost for backups is a bit trickier as Amazon does not charge directly for automated backups, rather the charges come from the amount of backup storage used which exceeds the size of the live database. To calculate this cost we would need to get the size of the backups and subtract the size of the live database. Maybe we should limit the scope of this PR to just adding the resource, Adding the cost could be a separate issue / PR |
Thanks for the update! |
6b6e06c
to
c98001b
Compare
In that case I've just rebased this branch to latest and its ready for merge 👍🏻 |
Problem
Ability to view RDS Auto Backup Resource does not exist.
Solution
This PR adds a new
providers/aws/rds/auto_backups.go
file which queries the AWS Go SDK and implements support for returning RDS AutoBackups.An entry has also been made to
providers/aws/aws.go
to make surerds.AutoBackups
is includedChanges Made
fixes #559
How to Test
Apply filter in Dashboard:
and you should be able to see RDS Backup.
Screenshots
wip
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
nope
Reviewers