Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter-button): repositioned filter button #902

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(filter-button): repositioned filter button #902

merged 1 commit into from
Jul 20, 2023

Conversation

shobhitexe
Copy link
Contributor

Problem

The filter button was not aligning with figma design

Solution

have removed the top filter button that was not in figma design

Changes Made

  • Removed the top Filter button from inventory.tsx and from InventoryHeader.tsx which is taking Filter button as its children
  • added a filter button to ActiveFilters component with same functionality as that top filter button
  • the svg of clearFilters occupying to much space in component exported that to different Svg component

Screenshots

2023-07-20.12-00-21.mp4

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy @ShubhamPalriwala

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @shobhitexe :)

@mlabouardy mlabouardy added this to the v3.1.0 milestone Jul 20, 2023
@mlabouardy mlabouardy added the ui label Jul 20, 2023
@mlabouardy mlabouardy merged commit fab973c into tailwarden:develop Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants