Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for AWS Load balancer Target Groups #913

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Added support for AWS Load balancer Target Groups #913

merged 2 commits into from
Aug 21, 2023

Conversation

pavangudiwada
Copy link
Contributor

@pavangudiwada pavangudiwada commented Aug 19, 2023 •
edited
Loading

Problem

Add support for AWS ELB Target Groups using Komiser. Closes #540

Changes Made

  • Added support for getting AWS ELB Target Groups(elb/targetgroups.go)
  • Added elb.TargetGroups to aws.go

How to Test

  • Make sure your AWS account has Target Groups
  • Build and run this branch
  • Choose Target Group as service filter

Screenshots

image

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

mlabouardy
mlabouardy approved these changes Aug 19, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a million @pavangudiwada

@mlabouardy mlabouardy added the aws label Aug 19, 2023
@mlabouardy mlabouardy added this to the v3.1.1 milestone Aug 19, 2023
@mlabouardy mlabouardy merged commit 4900d56 into tailwarden:develop Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.

Support Amazon Elastic Load Balancing targetgroup
2 participants
@pavangudiwada @mlabouardy