-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dependabot #925
add dependabot #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
wdyt @AvineshTripathi @ShubhamPalriwala
@shivam-sharma7 Thanks for raising up the PR firstly! If you could give more details about it that would be great! |
@AvineshTripathi for now let't keep this, for backend I need to investigate :) |
Sure works for me! However is there anything we should do to do the setup in our end any permissions or something? Also could you open an issue for backend with all links and resources you used for frontend which can be used by anyone who is willing to add backend support LGTM! |
Will do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shivam-sharma7, what do you think about setting the interval to weekly or biweekly? Daily seems too frequent to me and I have seen projects getting spammed by the dependabot at the same time!
@ShubhamPalriwala Here what I thought, we know our project is using lot of dep.. and if we set interval weekly then we can get many PR by dependabot right? because it might possible many dep.. got release within the a week. If we set daily then whatever dep... will release we will get PR and easy to merge. |
@shivam-sharma7 are you sure if time interval is set to weekly we will get many PRs. I think, maybe wrong but every week only one PR will be created |
11b2cdf
to
0fa6ec9
Compare
@AvineshTripathi I made a change. That was only my opnion |
Thanks! We can try weekly first and also if anything goes south we can always revert changes. |
can we merge this PR? |
@shivam-sharma7 have you tested it locally? |
0fa6ec9
to
3268982
Compare
@AvineshTripathi you can merge this. |
@shivam-sharma7 can you show me a demo setup on your fork how it will be functioning and what configurations are we suppose to do |
@AvineshTripathi See this is my project-https://github.com/shivam-sharma7/Expense-Tracker/pulls all the pull_request done by dependabot to manage my dep.. from older to newer. I hope you got it:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivam-sharma7 thanks for this PR, we can have same for backend and other parts too
fixes: #924
[Provide a brief description of the problem that you are trying to solve with this pull request.]
Solution
[Provide a detailed explanation of the solution you are proposing, including any relevant code snippets or screenshots.]
Changes Made
How to Test
[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]
Screenshots
[Include screenshots, if relevant, to help reviewers understand the changes you made.]
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@[AvineshTripathi]