Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependabot #925

Merged

Conversation

shivam-sharma7
Copy link
Contributor

fixes: #924

[Provide a brief description of the problem that you are trying to solve with this pull request.]

Solution

[Provide a detailed explanation of the solution you are proposing, including any relevant code snippets or screenshots.]

Changes Made

  • [List the changes you made in this pull request, including any new features or bug fixes.]

How to Test

[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]

Screenshots

[Include screenshots, if relevant, to help reviewers understand the changes you made.]

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[AvineshTripathi]

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvineshTripathi
Copy link
Collaborator

@shivam-sharma7 Thanks for raising up the PR firstly!
We also have backend written in golang so could you also look into that in the same PR. Also I am not sure what could be best way to handle both frontend and backend dependencies i.e. do we get two differnent PRs or same PR and the timing of the Pr(not sure if we could adjust that!)

If you could give more details about it that would be great!

@shivam-sharma7
Copy link
Contributor Author

@shivam-sharma7 Thanks for raising up the PR firstly! We also have backend written in golang so could you also look into that in the same PR. Also I am not sure what could be best way to handle both frontend and backend dependencies i.e. do we get two differnent PRs or same PR and the timing of the Pr(not sure if we could adjust that!)

If you could give more details about it that would be great!

@AvineshTripathi for now let't keep this, for backend I need to investigate :)

@AvineshTripathi
Copy link
Collaborator

@shivam-sharma7 Thanks for raising up the PR firstly! We also have backend written in golang so could you also look into that in the same PR. Also I am not sure what could be best way to handle both frontend and backend dependencies i.e. do we get two differnent PRs or same PR and the timing of the Pr(not sure if we could adjust that!)
If you could give more details about it that would be great!

@AvineshTripathi for now let't keep this, for backend I need to investigate :)

Sure works for me! However is there anything we should do to do the setup in our end any permissions or something? Also could you open an issue for backend with all links and resources you used for frontend which can be used by anyone who is willing to add backend support

LGTM!

@shivam-sharma7
Copy link
Contributor Author

@shivam-sharma7 Thanks for raising up the PR firstly! We also have backend written in golang so could you also look into that in the same PR. Also I am not sure what could be best way to handle both frontend and backend dependencies i.e. do we get two differnent PRs or same PR and the timing of the Pr(not sure if we could adjust that!)
If you could give more details about it that would be great!

@AvineshTripathi for now let't keep this, for backend I need to investigate :)

Sure works for me! However is there anything we should do to do the setup in our end any permissions or something? Also could you open an issue for backend with all links and resources you used for frontend which can be used by anyone who is willing to add backend support

LGTM!

Will do that

Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shivam-sharma7, what do you think about setting the interval to weekly or biweekly? Daily seems too frequent to me and I have seen projects getting spammed by the dependabot at the same time!

@shivam-sharma7
Copy link
Contributor Author

Hey @shivam-sharma7, what do you think about setting the interval to weekly or biweekly? Daily seems too frequent to me and I have seen projects getting spammed by the dependabot at the same time!

@ShubhamPalriwala Here what I thought, we know our project is using lot of dep.. and if we set interval weekly then we can get many PR by dependabot right? because it might possible many dep.. got release within the a week. If we set daily then whatever dep... will release we will get PR and easy to merge.

@AvineshTripathi
Copy link
Collaborator

@shivam-sharma7 are you sure if time interval is set to weekly we will get many PRs. I think, maybe wrong but every week only one PR will be created

@shivam-sharma7
Copy link
Contributor Author

@shivam-sharma7 are you sure if time interval is set to weekly we will get many PRs. I think, maybe wrong but every week only one PR will be created

@AvineshTripathi I made a change. That was only my opnion

@AvineshTripathi
Copy link
Collaborator

Thanks! We can try weekly first and also if anything goes south we can always revert changes.

@mlabouardy
Copy link
Collaborator

Thanks! We can try weekly first and also if anything goes south we can always revert changes.

can we merge this PR?

@AvineshTripathi
Copy link
Collaborator

@shivam-sharma7 have you tested it locally?

@shivam-sharma7
Copy link
Contributor Author

@shivam-sharma7 have you tested it locally?

@AvineshTripathi you can merge this.

@AvineshTripathi
Copy link
Collaborator

@shivam-sharma7 can you show me a demo setup on your fork how it will be functioning and what configurations are we suppose to do

@shivam-sharma7
Copy link
Contributor Author

@AvineshTripathi See this is my project-https://github.com/shivam-sharma7/Expense-Tracker/pulls

all the pull_request done by dependabot to manage my dep.. from older to newer. I hope you got it:)

Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivam-sharma7 thanks for this PR, we can have same for backend and other parts too

@AvineshTripathi AvineshTripathi merged commit 415ee5d into tailwarden:develop Sep 7, 2023
2 checks passed
@shivam-sharma7 shivam-sharma7 deleted the shivam-sharma7-dependabot branch September 7, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dependaboat
4 participants