Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ELB listener rules and change listener name #933

Merged

Conversation

pavangudiwada
Copy link
Contributor

@pavangudiwada pavangudiwada commented Sep 5, 2023

Problem

Solves #534 #535

Solution

  • Updated code to show Listener rules

Changes Made

  • Updated listener name from Listener ARN to ELB Name because its easy to identify using the ELB name.
  • Added support to display ELB Listener Rules based on the ELB Type.

How to Test

  • Make sure your AWS account has AWS Application/Network/Gateway ELB
  • Build and run this branch
  • Choose ELB App/Net/Gat Listener Rule as the service filter option.
  • Follow step 3 but pick ELB App/Net/Gat Listeners to verify the new Listner names.

Screenshots

image
image

Notes

  • Only tested using Application ELB. Should work for Network and Gateway too.

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@AvineshTripathi
Copy link
Collaborator

Hey @pavangudiwada I am planning to write a doc that defines standards for the resource struct i.e. what field holds what and we want that to be uniform across komiser so would you like to work on that with me since you've have been working of the naming conventions in your PR?

@pavangudiwada
Copy link
Contributor Author

Hi @AvineshTripathi, sure let's do it.

Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Havn't checked it running @mlabouardy can you do that but LGTM!

providers/aws/elb/loadbalancers.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside Avinesh comment, LGTM!

@mlabouardy mlabouardy added this to the v3.1.1 milestone Sep 10, 2023
@mlabouardy
Copy link
Collaborator

beside Avinesh comment, LGTM!

Let me know once you've the fix ready and we can merge the PR :) @pavangudiwada

@pavangudiwada
Copy link
Contributor Author

Updated based on comments @mlabouardy
image

@mlabouardy mlabouardy merged commit 314a7e9 into tailwarden:develop Sep 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants