-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ELB listener rules and change listener name #933
Added ELB listener rules and change listener name #933
Conversation
Hey @pavangudiwada I am planning to write a doc that defines standards for the resource struct i.e. what field holds what and we want that to be uniform across komiser so would you like to work on that with me since you've have been working of the naming conventions in your PR? |
Hi @AvineshTripathi, sure let's do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Havn't checked it running @mlabouardy can you do that but LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beside Avinesh comment, LGTM!
Let me know once you've the fix ready and we can merge the PR :) @pavangudiwada |
Updated based on comments @mlabouardy |
Problem
Solves #534 #535
Solution
Changes Made
How to Test
Screenshots
Notes
Checklist