-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/786 onboarding wizard #957
Merged
mlabouardy
merged 37 commits into
tailwarden:develop
from
Kolawole99:feature/786-onboarding-wizard
Sep 15, 2023
Merged
Feature/786 onboarding wizard #957
mlabouardy
merged 37 commits into
tailwarden:develop
from
Kolawole99:feature/786-onboarding-wizard
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… application semantics
Kolawole99
requested review from
mlabouardy,
ShubhamPalriwala and
AvineshTripathi
as code owners
September 12, 2023 11:30
@Oluwaseyi3 I am tagging you to this PR with this comment for tracking purposes. Once this PR merges, we can then share the tasks on the second portion of the onboarding wizard so you can build upon this updates. |
@Kolawole99 can you update the branch and let me know when you are ready for review |
mlabouardy
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are seeking to complete the second portion of the onboarding wizard, This portion exists when the user has gone through the initial portion of the Onboarding wizard flow and this portion of the wizard helps in managing the existing cloud accounts and also adding newer cloud accounts.
Solution
[Provide a detailed explanation of your proposed solution, including any relevant code snippets or screenshots.]
Changes Made
How to Test
Edit the beta flags in these portions of the application:
dashboard/components/layout/Layout.tsx: change
const betaFlagOnboardingWizard = false;
toconst betaFlagOnboardingWizard = true;
. This should be online 40
of the filedashboard/components/layout/hooks/useGlobalStats.tsx: change
setHasNoAccounts(true);
tosetHasNoAccounts(false);
. This should be online 34
of the fileScreenshots
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@[username of the reviewer]