Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the --button-width CSS variable on the PopoverPanel component #3058

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Expose the --button-width CSS variable on the PopoverPanel component #3058

merged 5 commits into from
Mar 26, 2024

Commits on Mar 26, 2024

  1. allow to pass direct values to useElementSize 

    Currently we require a `MutableRefObject<HTMLElement | null>`, but in
some situations (Popover) we don't have a ref, but the direct element.

This now supports passing in both.

Another fix could be to wrap the raw value in a ref but that feels like
an incorrect workaround.
    @RobinMalfait
    RobinMalfait committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    433236e View commit details
    Browse the repository at this point in the history

  2. mock ResizeObserver 

    This is necessary because jsdom doesn't implement `ResizeObserver` and
then it would just crash.
    @RobinMalfait
    RobinMalfait committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7ec181a View commit details
    Browse the repository at this point in the history

  3. expose --button-width on the PopoverPanel

    @RobinMalfait
    RobinMalfait committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1264638 View commit details
    Browse the repository at this point in the history

  4. update changelog

    @RobinMalfait
    RobinMalfait committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9d9241b View commit details
    Browse the repository at this point in the history

  5. replace instanceof HTMLElement check 

    The `instanceof HTMLElement` cannot be used because this also runs on
the server where `HTMLElement` is not available as a concrete class.
    @RobinMalfait
    RobinMalfait committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    82bb9c3 View commit details
    Browse the repository at this point in the history